--- target: whole app (crates/musyx/src) total_score: 22 max_score: 40 na_heuristics: p0_count: 1 p1_count: 2 target_identity: "file:/Users/yp/Projects/musyx/crates/musyx/src" timestamp: 2026-10-18T09-24-01Z slug: crates-musyx-src --- Method: dual-agent (A: design review · B: detector + pixel/source evidence). The app is native iced, so the web detector ran only on design/mockup.html. B replaced the browser overlay with contrast measured from snapshot pixels, hit-target measurements and static source scans. The evidence is 21 snapshots: dark/English and light/Russian, sample data, no network. ## Design Health Score | # | Heuristic | Score | Key Issue | |---|-----------|-------|-----------| | 1 | Visibility of System Status | 2 | Every loading state is a grey sentence. Buffering is drawn as a half-alpha pause glyph that renders as a normal one, because the SVG tint drops alpha. The playing row can't show paused. | | 2 | Match System / Real World | 3 | Copy and Russian plurals are strong. "Tap the heart" is phone wording in a desktop app. Up to three "Go to artist" items appear without names. | | 3 | User Control and Freedom | 2 | Dislike can't be undone, and nothing lists disliked tracks. One click replaces the queue. The queue is read-only. Esc closes nothing. | | 4 | Consistency and Standards | 2 | The track menu opens as a centred modal, with no right-click. Space doesn't toggle playback. Play sits in a different place on list screens than on detail screens. | | 5 | Error Prevention | 2 | The one-click Dislike sits 12px from Like. It skips the track and silently unlikes it. | | 6 | Recognition Rather Than Recall | 2 | 16 icon-only buttons have no tooltips. Chart is missing from the nav. | | 7 | Flexibility and Efficiency | 1 | There are no in-app shortcuts, no multi-select, no filter on Liked tracks and no drag reordering. | | 8 | Aesthetic and Minimalist Design | 3 | The design is quiet and coherent. The hero is repeated on Home and My Wave, and "more" shows on every row. | | 9 | Error Recovery | 3 | Every failure names the next step and offers "Try again". Failures look the same as loading text. | | 10 | Help and Documentation | 2 | The sign-in steps and quality explanations are good. There is no shortcut list or tuning hint, and "OAuth token" appears on the first screen. | | **Total** | | **22/40** | **Acceptable** | ## Design Specificity Verdict **LLM assessment:** The structure belongs to Yandex Music; the interaction layer could belong to any player. My Wave is the hero, mood, character and language tuning is built in, Dislike sits in the player bar, Plus status and 30-second previews are explained, and "Podcasts and books" mirrors Yandex's catalogue. Aubergine with a single amber, Unbounded and the dotted wordmark make a real identity, and it holds in both themes. But the shell is the standard Spotify layout: a 232px sidebar, pill search, a three-zone player bar and a numbered table with a clock icon over durations. The "tape-deck VU needle" behind the accent appears only in DESIGN.md: nothing in the app moves like a needle. The hero is 14 generic sine lines, identical on Home and My Wave, and they hold still until My Wave plays. The build also loses most of the mockup's character: the Tune button in the hero, display-face chart ranks, the card hover play, the animated equaliser on the playing row, and the live sign-in canvas. **Deterministic scan:** On design/mockup.html the detector found 10 low-contrast findings, all in the light palette. Nine are `#FFF7E6` on `#A86C05` at 4.1:1, which covers primary buttons and pressed segments. One is `#2E8A55` on white at 4.3:1 ("Plus subscription"). Both carry over to the iced app, and the second is worse there: the sidebar renders on `bg`, not `panel`, so "Подписка Плюс" measures 3.83:1 in pixels. The play-fab finding is mockup-only. The scan found no false positives for the native app. Beyond what the review saw, the measurements show: - Disabled prev/next render at full `muted`, so the 0.45 alpha is lost. - The seek rail is 1.13:1 against the player bar, so it is invisible when idle. - Line borders on ghost buttons and chips are 1.3–1.5:1. - The danger button is white on `like` at 2.79:1 in dark. - 19 hardcoded colours sit outside theme.rs, including a non-token `#4A4458`. - 16 font sizes and 52 spacing values are off the scale. theme.rs matches DESIGN.md exactly, 10 of 10 tokens. **Visual overlays:** None. iced exposes no DOM or CDP, so nothing was injected. ## Overall Impression Musyx is a well-built, disciplined player: the tokens are exact, the copy is excellent in both languages, and the OS integration is real. The weak spot is how the app reacts to input. It ignores the keyboard, routine track actions open a modal, the most destructive one-click action has no undo, and several state changes never reach the screen. The biggest opportunity is to make it behave like a desktop app: keys, right-click, focus, undo. After that, give the VU-needle idea a real form so the identity lives in the controls and not just in the colours. ## What's Working 1. **Token discipline and dark-mode legibility.** Every sampled pixel matched its token. Every dark-mode text pair passes: muted on bg is 6.5:1, accent_ink on accent 8.7:1, accent on bg 9.1:1. The chip, tab and ghost styles are shared by Settings, My Wave and Search. 2. **Copy and localisation craft.** - 253 keys, none missing in Russian. - Correct Russian plurals, genitive months and "4,1 млн"-style numbers. - Quality options state their cost. - Every error names the next step. "You're still signed in" on the offline screen is exactly the reassurance that moment needs. 3. **Native integration.** - Media keys and Now Playing through souvlaki. - A macOS menu-bar mini player that appears only when the window is minimised. - Lazy track lists that don't rebuild on every position tick. ## Priority Issues **[P0] There is no keyboard path.** - *Why:* app.rs:265 subscribes to theme, audio, media keys and timers, and nothing else. Buttons have no focused style, so Tab reaches only text inputs. Space, Cmd/Ctrl+F and Esc do nothing. `topbar::SEARCH_ID` is defined but never focused, even when you click Search. People keep a player open for hours, and a keyboard-only user can't use it at all. - *Fix:* add an `iced::event::listen_with` keyboard subscription, ignored while a text input has focus: - Space: play/pause. - Cmd/Ctrl+F or `/`: focus search. - Esc: close the sheet, then the drawer, then suggestions. - Cmd+←/→: previous/next track. - Cmd+↑/↓: volume. - Cmd+L: like. - Cmd+[: back. - Cmd+1–5: nav items. Also focus the field on `Navigate(Route::Search)`, and add a focus ring through a focusable wrapper. - *Suggested command:* /impeccable harden **[P1] The track menu is a modal centred on the window.** - *Why:* sheet.rs:40 dims the whole window for routine actions. It lists 8–13 items with one divider, repeats "Go to artist" without names, and stays open after an action. Reordering a playlist means reopening it once per position. There is no right-click, which breaks the most basic desktop convention for a list. - *Fix:* - Open the menu from `mouse_area::on_right_press` on rows, or from "…", as a popover at the cursor. - Use three groups: (Play next, Add to queue) · (Like, Add to playlist…, Don't recommend) · (Go to album, Go to {artist name}). - Close the menu on action and confirm with a toast. - Bring back the mockup's grip column for drag reordering. - *Suggested command:* /impeccable shape **[P1] Dislike fires on one click, with hidden side effects and no recovery.** - *Why:* the unlabelled ban icon sits 12px from the heart (player_bar.rs:86). One click skips the track, removes it from Liked tracks (edit.rs:76) and shows a toast with no undo. The Disliked tab from the mockup was dropped, so nothing in the app lists dislikes. A mis-click silently loses a liked track. - *Fix:* - Add Undo to the toast: re-like the track and send `DislikeTrack(track, false)`. - Add a tooltip. - Space Dislike away from Like. - Restore the Disliked tab in collection.rs. - *Suggested command:* /impeccable harden **[P2] The light theme and the boundaries fail contrast.** The detector and the pixels agree. - *Why:* light accent_ink on accent is 4.09:1, which covers every primary button and selected chip. Light accent as text is 3.89:1: the playing row, the current track in the drawer, the Lossless badge. ok text is 3.83:1. In both themes, the seek and volume rails are about 1.1–1.2:1 and the line borders 1.3–1.5:1. The dark danger button is 2.79:1. Genre tiles put white text on colours from the API without checking contrast. In light, the selected nav fill is about 1.1:1 against bg, so only the amber icon marks the current page. - *Fix:* - Light accent `#8F5B00` (5.4:1 with ink, 5.1:1 on bg). - Light ok `#25744A`. - Rail track at `line` or brighter. - A dark-ink label on the danger button. - A luminance-based text colour or a scrim on genre tiles. - A 2–3px amber bar on the active nav row. - Update DESIGN.md alongside theme.rs. - *Suggested command:* /impeccable colorize (palette correction), then /impeccable audit **[P2] Several states never reach the screen.** - *Why:* `svg::Style::color` ignores alpha. B measured disabled prev/next at full `muted`. The same code path should make the Loading disc look identical to Playing (player_bar.rs:116), and the idle row heart look like an enabled control (track_row.rs:97); these two weren't captured in snapshots. The playing row uses a static glyph, so pause doesn't show. Errors use the loading paragraph style. The album column is cut mid-glyph with no ellipsis ("Солнц", "любов" with the drawer open). On light/RU Home, the two-line subtitle pushes the hero title 14pt into the wave lines. - *Fix:* - Pass fully opaque tints that are pre-mixed with the surface instead of using `scale_alpha` on icons. - Show buffering as a spinner or pulsing ring on the disc. - Make the playing indicator an animated meter that freezes when paused. - Give errors an icon and a `like` lead line. - Add ellipsis truncation or a fade mask for the album column. - Anchor the wave band to the hero's top, or add a scrim under the title. - *Suggested command:* /impeccable polish ## Persona Red Flags **Alex (power user)** - No shortcuts. - A single click plays and replaces the queue, so there is no selection or batch "Add to playlist". - No filter or sort on a Liked list of 1,000+ tracks. - The queue can't be edited: no remove, reorder or clear. - Reordering a playlist takes one modal per position. - Chart is reachable only through Home's "Show all". - The window title doesn't show the track that is playing. **Sam (keyboard-only, low vision)** - Tab reaches no button, and there is no focus indicator. - 16 icon buttons have no tooltip. iced 0.14 exposes no accessibility tree, so screen readers get nothing; the README should say so. - Light-theme failures at 3.8–4.1:1. - The paused and playing states differ only by colour and a static glyph. - Text sizes are 11.5–12.5pt for the quality badge, the plan line and the player times. **Jordan (first-timer)** - Sign-in adds a "Get sign-in code" click before any code appears. - The QR area is a white card with a grey lock, which reads as locked or broken. - "OAuth token" appears on the first screen. - Clicking Search opens a page titled "Browse" with no cursor in the field. - The microphone icon means lyrics, and nothing labels it. - First Home is a stack of "Loading…" lines next to a disabled grey play disc that could have offered "Play My Wave". ## Minor Observations - **Detail pages:** Play and Shuffle sit in a separate right-aligned row with an empty left half (detail.rs:181). On your own playlist, Delete sits next to the title while Play is lower down. Put Play, Shuffle, heart and "…" together in the header, and move Rename, visibility and Delete into "…". - **Sidebar:** DESIGN.md says it uses the `panel` fill, but it renders on `bg` (app.rs:1037). The playlist list mixes owned and liked playlists without a divider. - **"More" on rows:** DESIGN.md says it appears on hover, but it is always visible. - **Volume fill:** it uses `fg`, which makes it the brightest mark in the player bar and pulls attention from the amber progress bar. - **Scroll position:** the page scrollable has no id and is never reset, so new routes may open at the old offset and Back doesn't restore position. This was not confirmed at runtime. - **"Show all":** the links use the tab style, which reads as a tab rather than a link. - **Collection tabs:** the counts pop in one at a time. - **Off-scale values:** about 16 font sizes (13.5 ×6, 12, 15, 17, 11.5, 9) and 52 spacing values (16 ×9, 9 ×8, 24 ×7) are off the DESIGN.md scale. Either fold them in or record them. - **Podcasts:** the mockup's "Continue listening" is gone, so there is no resume point for podcasts or audiobooks. ## Questions to Consider - If the accent is a VU needle, why does nothing move like one? Should the seek or volume control become the needle, with a sweep and settle on each track change, and the generic sine lines retired? - Home and My Wave show the same hero. Once My Wave is playing, should Home give that space to "Continue" content, or should My Wave simply be the home screen? - What would Musyx feel like with desktop selection rules: click selects, double-click or Enter plays, Space toggles, right-click opens the menu? Does a one-click Dislike belong in the player bar during a session that lasts hours?